Date: Sat, 13 Nov 2004 10:48:09 +0000
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI fixes for 2.6.10-rc1
Message-ID: <20041113104809.B646@flint.arm.linux.org.uk>
Mail-Followup-To: Jan Dittmer <jdittmer@ppp0.net>, Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org
References: <1100301717571@kroah.com> <11003017181402@kroah.com> <20041113091208.A30939@flint.arm.linux.org.uk> <4195DBE3.9000606@ppp0.net> <20041113102205.A646@flint.arm.linux.org.uk> <4195E5AC.7030904@ppp0.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <4195E5AC.7030904@ppp0.net>; from jdittmer@ppp0.net on Sat, Nov 13, 2004 at 11:45:00AM +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1351
Lines: 32

On Sat, Nov 13, 2004 at 11:45:00AM +0100, Jan Dittmer wrote:
> > This sounds very wrong.  Why did it get removed from bus->devices ?
> > 
> > If it isn't on bus->devices, how does pci_bus_add_device() help?
> > Sure you get it onto the global list and into the device tree,
> > but it won't be attached to the parent bus properly.
> > 
> > I think what you want to be using is:
> > 
> > int __devinit pci_scan_slot(struct pci_bus *bus, int devfn)
> > 
> > to discover the new device, which will do the right thing from the
> > point of setting stuff up before calling pci_bus_add_device*().
> > 
> 
> I don't see how pci_scan_slot helps me here. I already call
> pci_scan_single_device which seems just about the same.

Which is also acceptable.  The device will be on the bus->devices list.
I still don't see why you can't use pci_bus_add_devices() though, or
why you think you need to remove it from the bus->devices list.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/