Message-ID: <4195E8C0.9010000@ppp0.net>
Date: Sat, 13 Nov 2004 11:58:08 +0100
From: Jan Dittmer <jdittmer@ppp0.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040926 Thunderbird/0.8 Mnenhy/0.6.0.104
MIME-Version: 1.0
To: Russell King <rmk+lkml@arm.linux.org.uk>
CC: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI fixes for 2.6.10-rc1
References: <1100301717571@kroah.com> <11003017181402@kroah.com> <20041113091208.A30939@flint.arm.linux.org.uk> <4195DBE3.9000606@ppp0.net> <20041113102205.A646@flint.arm.linux.org.uk> <4195E5AC.7030904@ppp0.net> <20041113104809.B646@flint.arm.linux.org.uk>
In-Reply-To: <20041113104809.B646@flint.arm.linux.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1388
Lines: 36

Russell King wrote:
> On Sat, Nov 13, 2004 at 11:45:00AM +0100, Jan Dittmer wrote:
> 
>>>This sounds very wrong.  Why did it get removed from bus->devices ?
>>>
>>>If it isn't on bus->devices, how does pci_bus_add_device() help?
>>>Sure you get it onto the global list and into the device tree,
>>>but it won't be attached to the parent bus properly.
>>>
>>>I think what you want to be using is:
>>>
>>>int __devinit pci_scan_slot(struct pci_bus *bus, int devfn)
>>>
>>>to discover the new device, which will do the right thing from the
>>>point of setting stuff up before calling pci_bus_add_device*().
>>>
>>
>>I don't see how pci_scan_slot helps me here. I already call
>>pci_scan_single_device which seems just about the same.
> 
> 
> Which is also acceptable.  The device will be on the bus->devices list.
> I still don't see why you can't use pci_bus_add_devices() though, or
> why you think you need to remove it from the bus->devices list.
> 

It's needed for fakephp, where the device gets removed from bus->devices
if you disable the slot. pci_scan_single_device then re-adds the
device to the list when enabling the slot again.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/