Date: Sat, 13 Nov 2004 22:10:16 -0800
From: William Lee Irwin III <wli@holomorphy.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: jgarzik@pobox.com, viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: Parenthize nth_page() macro arg, in linux/mm.h.
Message-ID: <20041114061016.GF3217@holomorphy.com>
References: <200411140517.iAE5HOqM010399@hera.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200411140517.iAE5HOqM010399@hera.kernel.org>
User-Agent: Mutt/1.5.6+20040722i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1098
Lines: 26

On Sat, Nov 13, 2004 at 07:43:08PM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2092.7.2, 2004/11/13 14:43:08-05:00, jgarzik@pobox.com
> 	Parenthize nth_page() macro arg, in linux/mm.h.
>  mm.h |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> diff -Nru a/include/linux/mm.h b/include/linux/mm.h
> --- a/include/linux/mm.h	2004-11-13 21:17:35 -08:00
> +++ b/include/linux/mm.h	2004-11-13 21:17:35 -08:00
> @@ -41,7 +41,7 @@
>  #define MM_VM_SIZE(mm)	TASK_SIZE
>  #endif
> -#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + n)
> +#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))

Okay, #1 the ((page)) thing should be unnecessary. If it is necessary,
arch code is broken, which leads to #2: this came about because alpha
wasn't parenthesizing its args in pfn_to_page(); where did the fix for
that go?


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/