Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261424AbUKOBRD (ORCPT ); Sun, 14 Nov 2004 20:17:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261406AbUKOBQy (ORCPT ); Sun, 14 Nov 2004 20:16:54 -0500 Received: from ozlabs.org ([203.10.76.45]:57009 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S261425AbUKOBOv (ORCPT ); Sun, 14 Nov 2004 20:14:51 -0500 Subject: Re: [PATCH] handle quoted module parameters From: Rusty Russell To: "Randy.Dunlap" Cc: yiding_wang@agilent.com, arjan@infradead.org, lkml - Kernel Mailing List , Andrew Morton In-Reply-To: <41943931.4090008@osdl.org> References: <08A354A3A9CCA24F9EE9BE13600CFBC50F3AED@wcosmb07.cos.agilent.com> <41943754.6090806@osdl.org> <41943931.4090008@osdl.org> Content-Type: text/plain Date: Mon, 15 Nov 2004 12:14:47 +1100 Message-Id: <1100481287.7381.20.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 26 On Thu, 2004-11-11 at 20:16 -0800, Randy.Dunlap wrote: > Here's a patch with better description. > > > Fix module parameter quote handling. > Module parameter strings (with spaces) are quoted like so: > "modprm=this test" > and not like this: > modprm="this test" Well, the quote handling in insmod was ripped out after 3.0, exactly because it was broken like this. But modprobe will use the latter form, since it will paste it straight from the modprobe.conf file (which needs quotes in options lines). Hope that clarifies, Rusty. PS. module-init-tools 3.1 just out... -- A bad analogy is like a leaky screwdriver -- Richard Braakman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/