Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261550AbUKOIsr (ORCPT ); Mon, 15 Nov 2004 03:48:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261556AbUKOIsr (ORCPT ); Mon, 15 Nov 2004 03:48:47 -0500 Received: from vanessarodrigues.com ([192.139.46.150]:23969 "EHLO jaguar.mkp.net") by vger.kernel.org with ESMTP id S261550AbUKOIsf (ORCPT ); Mon, 15 Nov 2004 03:48:35 -0500 To: Adrian Bunk Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] SCSI qla1280: some firmware files cleanups References: <20041115022640.GX2249@stusta.de> From: Jes Sorensen Date: 15 Nov 2004 03:48:34 -0500 In-Reply-To: <20041115022640.GX2249@stusta.de> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 12 >>>>> "Adrian" == Adrian Bunk writes: Adrian> The patch below does the following changes to the qla1280 Adrian> firmware files: - make all this needlessly global code static Adrian> - remove the unused firmware_version variables Looks fine to me, though some of those could maybe even be turned into #define's. Cheers, Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/