Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261703AbUKOUp2 (ORCPT ); Mon, 15 Nov 2004 15:45:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261695AbUKOUn5 (ORCPT ); Mon, 15 Nov 2004 15:43:57 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:39625 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S261693AbUKOUlN (ORCPT ); Mon, 15 Nov 2004 15:41:13 -0500 Date: Mon, 15 Nov 2004 21:41:00 +0100 (MET) From: Jan Engelhardt To: Dean Nelson cc: Chris Wright , akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [Patch] export sched_setscheduler() for kernel module use In-Reply-To: <20041115203343.GA32173@sgi.com> Message-ID: References: <4198F70D.mailxMSZ11J00J@aqua.americas.sgi.com> <20041115105801.T14339@build.pdx.osdl.net> <20041115203343.GA32173@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 25 >> * Dean Nelson (dcn@sgi.com) wrote: >> > +int do_sched_setscheduler(pid_t pid, int policy, struct sched_param __user *param) >> >> this should be static. > >You're right. I made another change in that one now passes the task_struct >pointer to sched_setscheduler() instead of the pid. This requires that >the caller of sched_setscheduler() hold the tasklist_lock. The new patch >for people's feedback follows. Hi, can you elaborate a little why passing the task struct/pid is better/worse, respectively? Jan Engelhardt -- Gesellschaft für Wissenschaftliche Datenverarbeitung Am Fassberg, 37077 Göttingen, www.gwdg.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/