Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261392AbUKPJxU (ORCPT ); Tue, 16 Nov 2004 04:53:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261675AbUKPJvk (ORCPT ); Tue, 16 Nov 2004 04:51:40 -0500 Received: from cantor.suse.de ([195.135.220.2]:49620 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S261392AbUKPJqv (ORCPT ); Tue, 16 Nov 2004 04:46:51 -0500 Date: Tue, 16 Nov 2004 10:46:11 +0100 Message-ID: From: Takashi Iwai To: Lee Revell Cc: Paul Blazejowski , Linus Torvalds , LKML , Diffie , alsa-devel Subject: Re: [Alsa-devel] Re: Linux 2.6.10-rc2 In-Reply-To: <1100553392.4369.1.camel@krustophenia.net> References: <9dda349204111512234f30c60d@mail.gmail.com> <1100553392.4369.1.camel@krustophenia.net> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 36 At Mon, 15 Nov 2004 16:16:31 -0500, Lee Revell wrote: > > Please report ALSA issues to alsa-devel@lists.sourceforge.net. I have > added them to the cc:. The attached patch should fix this. Takashi == Summary: [ALSA] fix sleep in atomic during prepare callback Fixed the sleep in spinlock during prepare callback. This happened only on Nforce chips. Signed-off-by: Takashi Iwai --- linux/sound/pci/intel8x0.c 15 Nov 2004 14:19:52 -0000 1.173 +++ linux/sound/pci/intel8x0.c 16 Nov 2004 09:41:47 -0000 @@ -1020,7 +1020,9 @@ static void snd_intel8x0_setup_pcm_out(i */ if (cnt & ICH_PCM_246_MASK) { iputdword(chip, ICHREG(GLOB_CNT), cnt & ~ICH_PCM_246_MASK); + spin_unlock_irq(&chip->reg_lock); msleep(50); /* grrr... */ + spin_lock_irq(&chip->reg_lock); } } else if (chip->device_type == DEVICE_INTEL_ICH4) { if (runtime->sample_bits > 16) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/