Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262093AbUKQAsM (ORCPT ); Tue, 16 Nov 2004 19:48:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262126AbUKQApy (ORCPT ); Tue, 16 Nov 2004 19:45:54 -0500 Received: from mail.dif.dk ([193.138.115.101]:10936 "EHLO mail.dif.dk") by vger.kernel.org with ESMTP id S262146AbUKQAm4 (ORCPT ); Tue, 16 Nov 2004 19:42:56 -0500 Date: Wed, 17 Nov 2004 01:52:08 +0100 (CET) From: Jesper Juhl To: "Luiz Fernando N. Capitulino" Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, davem@davemloft.net Subject: Re: [PATCH 1/2] - net/socket.c::sys_bind() cleanup. In-Reply-To: <20041116185517.3314ac35.lcapitulino@conectiva.com.br> Message-ID: References: <20041116185517.3314ac35.lcapitulino@conectiva.com.br> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 32 On Tue, 16 Nov 2004, Luiz Fernando N. Capitulino wrote: > > Hi, > > net/socket.c::sys_bind() is a bit complex function, the patch > bellow makes it more clear. > > Note that the code does the same thing, it only makes difference > for the programmer. > Not exactely : > - if((err=move_addr_to_kernel(umyaddr,addrlen,address))>=0) { > + err = move_addr_to_kernel(umyaddr, addrlen, address); > + if (err) > + goto out_put; The original tests for err >= 0, your replacement tests if err is != 0 -- Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/