Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262208AbUKQEQq (ORCPT ); Tue, 16 Nov 2004 23:16:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262207AbUKQEQq (ORCPT ); Tue, 16 Nov 2004 23:16:46 -0500 Received: from mx1.redhat.com ([66.187.233.31]:3798 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262206AbUKQEQe (ORCPT ); Tue, 16 Nov 2004 23:16:34 -0500 Date: Tue, 16 Nov 2004 23:16:18 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Jesper Juhl cc: "Luiz Fernando N. Capitulino" , , , Subject: Re: [PATCH 1/2] - net/socket.c::sys_bind() cleanup. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 30 On Wed, 17 Nov 2004, Jesper Juhl wrote: > Not exactely : > > > > - if((err=move_addr_to_kernel(umyaddr,addrlen,address))>=0) { > > > + err = move_addr_to_kernel(umyaddr, addrlen, address); > > + if (err) > > + goto out_put; > > > The original tests for err >= 0, your replacement tests if err is != 0 Look at move_addr_to_kernel(), it only returns 0 or -error. The patch looks good to me. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/