Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262482AbUKQR1P (ORCPT ); Wed, 17 Nov 2004 12:27:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262467AbUKQR0w (ORCPT ); Wed, 17 Nov 2004 12:26:52 -0500 Received: from fire.osdl.org ([65.172.181.4]:32651 "EHLO fire-1.osdl.org") by vger.kernel.org with ESMTP id S262432AbUKQRZx (ORCPT ); Wed, 17 Nov 2004 12:25:53 -0500 Message-ID: <419B869B.5030603@osdl.org> Date: Wed, 17 Nov 2004 09:12:59 -0800 From: "Randy.Dunlap" Organization: OSDL User-Agent: Mozilla Thunderbird 0.9 (X11/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Oleg Nesterov CC: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] trivial, uninline do_trap(), remove get_cr2() References: <419B64C2.CED2FABC@tv-sign.ru> In-Reply-To: <419B64C2.CED2FABC@tv-sign.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 30 Oleg Nesterov wrote: > Uninlining do_trap() saves 544 bytes in traps.o. > get_cr2() seems to be unused, remove it. > > Signed-off-by: Oleg Nesterov > > --- 2.6.10-rc2/arch/i386/kernel/traps.c~ Tue Nov 16 14:13:08 2004 > +++ 2.6.10-rc2/arch/i386/kernel/traps.c Wed Nov 17 16:47:41 2004 > @@ -358,16 +358,7 @@ static inline void die_if_kernel(const c > die(str, regs, err); > } > > -static inline unsigned long get_cr2(void) > -{ > - unsigned long address; > - > - /* get the address */ > - __asm__("movl %%cr2,%0":"=r" (address)); > - return address; > -} Looks like it can be removed from arch/x86_64/kernel/traps.c also. -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/