Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262470AbUKQR1O (ORCPT ); Wed, 17 Nov 2004 12:27:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262485AbUKQRYQ (ORCPT ); Wed, 17 Nov 2004 12:24:16 -0500 Received: from fw.osdl.org ([65.172.181.6]:2733 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262415AbUKQQzb (ORCPT ); Wed, 17 Nov 2004 11:55:31 -0500 Date: Wed, 17 Nov 2004 08:55:25 -0800 (PST) From: Linus Torvalds To: Bartlomiej Zolnierkiewicz cc: linux-dev@morknet.de, Kernel Mailing List , trivial@rustcorp.com.au Subject: Re: [PATCH] dss1_divert ISDN module compile fix for kernel 2.6.8.1 In-Reply-To: <58cb370e0411170828365d1982@mail.gmail.com> Message-ID: References: <419B662D.5020904@morknet.de> <58cb370e0411170828365d1982@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 19 On Wed, 17 Nov 2004, Bartlomiej Zolnierkiewicz wrote: > > This looks wrong, you are using many private spinlocks instead > of one global spinlock. Good catch, I didn't look closely enough. Steffen, can you make that "divert_lock" one global one, and re-test? I'd do it myself, but it really does need testing, since there might be a deadlock lurking there that the local lock bug hid. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/