Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262665AbUKRIe4 (ORCPT ); Thu, 18 Nov 2004 03:34:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262669AbUKRIe4 (ORCPT ); Thu, 18 Nov 2004 03:34:56 -0500 Received: from gaz.sfgoth.com ([69.36.241.230]:26848 "EHLO gaz.sfgoth.com") by vger.kernel.org with ESMTP id S262665AbUKRIez (ORCPT ); Thu, 18 Nov 2004 03:34:55 -0500 Date: Thu, 18 Nov 2004 00:37:52 -0800 From: Mitchell Blank Jr To: Ian Pratt Cc: linux-kernel@vger.kernel.org, Keir.Fraser@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk Subject: Re: [patch 2] Xen core patch : arch_free_page return value Message-ID: <20041118083752.GA35159@gaz.sfgoth.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 28 One tiny suggestion... Ian Pratt wrote: > -void arch_free_page(struct page *page, int order) > +int arch_free_page(struct page *page, int order) How about just changing that to... void __arch_free_page(struct page *page, int order) ... and leave the rest of the function alone. Then: > -extern void arch_free_page(struct page *page, int order); > +extern int arch_free_page(struct page *page, int order); Do... extern void __arch_free_page(struct page *page, int order); #define arch_free_page(page, order) (__arch_free_page((page), (order)), 0) That way the compiler can omit the "if(...) return" even on UML -Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/