Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262709AbUKRKLb (ORCPT ); Thu, 18 Nov 2004 05:11:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262713AbUKRKLb (ORCPT ); Thu, 18 Nov 2004 05:11:31 -0500 Received: from phoenix.infradead.org ([81.187.226.98]:43783 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S262709AbUKRKLM (ORCPT ); Thu, 18 Nov 2004 05:11:12 -0500 Date: Thu, 18 Nov 2004 10:11:09 +0000 From: Christoph Hellwig To: Ian Pratt Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, Keir.Fraser@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk Subject: Re: [patch 1] Xen core patch : ptep_establish_new Message-ID: <20041118101109.GA20859@infradead.org> Mail-Followup-To: Christoph Hellwig , Ian Pratt , linux-kernel@vger.kernel.org, akpm@osdl.org, Keir.Fraser@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 21 On Wed, Nov 17, 2004 at 11:46:50PM +0000, Ian Pratt wrote: > > This patch adds 'ptep_establish_new', in keeping with the > existing 'ptep_establish', but for use where a mapping is being > established where there was previously none present. This > function is useful (rather than just using set_pte) because > having the virtual address available enables a very important > optimisation for arch-xen. We introduce > HAVE_ARCH_PTEP_ESTABLISH_NEW and define a generic implementation > in asm-generic/pgtable.h, following the pattern of the existing > ptep_establish. What would be the problem of always passing the virtual address to ptep_establish? We already have a rather twisted maze of pte manipulation macros. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/