Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262693AbUKRKNX (ORCPT ); Thu, 18 Nov 2004 05:13:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262706AbUKRKLt (ORCPT ); Thu, 18 Nov 2004 05:11:49 -0500 Received: from mta1.cl.cam.ac.uk ([128.232.0.15]:31447 "EHLO mta1.cl.cam.ac.uk") by vger.kernel.org with ESMTP id S262693AbUKRKJl (ORCPT ); Thu, 18 Nov 2004 05:09:41 -0500 To: Gerd Knorr cc: Andrew Morton , Ian Pratt , linux-kernel@vger.kernel.org, Keir.Fraser@cl.cam.ac.uk, Christian.Limpach@cl.cam.ac.uk, alan@redhat.com, Ian.Pratt@cl.cam.ac.uk Subject: Re: [patch 3] Xen core patch : runtime VT console disable In-reply-to: Your message of "18 Nov 2004 10:59:05 +0100." <87oehvxyty.fsf@bytesex.org> Date: Thu, 18 Nov 2004 10:09:31 +0000 From: Ian Pratt Message-Id: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 20 > Andrew Morton writes: > > > > +int console_use_vt = 1; > > > > Should this not have static scope? > > I'd like to have that one globally visible, so that code somewhere in > arch/{xen|um} can enable/disable that at boot time depending on the > virtual machine configuration. Yep, that's why we need it global. In arch/xen/i386/kernel/setup.c we set it to zero if the virtual machine doesn't have access to the console hardware. Ian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/