Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262778AbUKRRCM (ORCPT ); Thu, 18 Nov 2004 12:02:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262780AbUKRRCM (ORCPT ); Thu, 18 Nov 2004 12:02:12 -0500 Received: from mx1.redhat.com ([66.187.233.31]:51883 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262778AbUKRRCB (ORCPT ); Thu, 18 Nov 2004 12:02:01 -0500 Date: Thu, 18 Nov 2004 12:01:34 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Chris Wright cc: Ross Kendall Axe , , Stephen Smalley , lkml , "David S. Miller" Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET In-Reply-To: <20041118084449.Z14339@build.pdx.osdl.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 804 Lines: 28 On Thu, 18 Nov 2004, Chris Wright wrote: > Why not make a unix_seq_sendmsg, which is a very small wrapper? Good idea, patch forthcoming. > Does the above stop the other issue? My laptop died, so I'm not able to > test ATM. No, it seems to be caused when addrlen in sendto() is non-zero, causing unix_find_other() to be called instead of unix_peer_get(), which is screwing up reference counts. As for MSG_EOR, apart from the generic socket code, nothing is being done. This would be a separate issue. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/