Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262923AbUKRWx5 (ORCPT ); Thu, 18 Nov 2004 17:53:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261191AbUKRWv2 (ORCPT ); Thu, 18 Nov 2004 17:51:28 -0500 Received: from adsl-63-197-226-105.dsl.snfc21.pacbell.net ([63.197.226.105]:40081 "EHLO cheetah.davemloft.net") by vger.kernel.org with ESMTP id S262923AbUKRWud (ORCPT ); Thu, 18 Nov 2004 17:50:33 -0500 Date: Thu, 18 Nov 2004 14:34:51 -0800 From: "David S. Miller" To: James Morris Cc: chrisw@osdl.org, ross.axe@blueyonder.co.uk, netdev@oss.sgi.com, sds@epoch.ncsc.mil, linux-kernel@vger.kernel.org Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET Message-Id: <20041118143451.3dae3ffb.davem@davemloft.net> In-Reply-To: References: X-Mailer: Sylpheed version 0.9.99 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 26 On Thu, 18 Nov 2004 12:25:21 -0500 (EST) James Morris wrote: > Updated patch below (with Chris Wright's wrapper idea). > > This now fixes both issues. > > 1) Don't call security_unix_may_send() hook during sendmsg() for > SOCK_SEQPACKET, and ensure that sendmsg() can only be called on a > connected socket so as not to bypass the security_unix_stream_connect() > hook. > > 2) Return -EINVAL if sendto() is called on SOCK_SEQPACKET with an address > supplied. > > Please review and apply if ok. > > > Signed-off-by: James Morris Looks good, applied thanks James. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/