Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263006AbUKSAoc (ORCPT ); Thu, 18 Nov 2004 19:44:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261205AbUKSAoC (ORCPT ); Thu, 18 Nov 2004 19:44:02 -0500 Received: from clock-tower.bc.nu ([81.2.110.250]:60649 "EHLO localhost.localdomain") by vger.kernel.org with ESMTP id S261221AbUKSAnZ (ORCPT ); Thu, 18 Nov 2004 19:43:25 -0500 Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET From: Alan Cox To: James Morris Cc: Ross Kendall Axe , netdev@oss.sgi.com, Stephen Smalley , lkml , Chris Wright , "David S. Miller" In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1100821144.6005.40.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Thu, 18 Nov 2004 23:39:32 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 16 On Iau, 2004-11-18 at 18:40, James Morris wrote: > One thing that looks broken (unrelated to the patch I posted) is that > unix_dgram_sendmsg() already does not check sk->sk_shutdown & > SEND_SHUTDOWN for SOCK_SEQPACKET. Looks like a real bug yes. As to the other stuff I think the only change needed is to check the queued asynchronous error and report that before going on to the connected test - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/