Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261399AbUKSNLV (ORCPT ); Fri, 19 Nov 2004 08:11:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261400AbUKSNLV (ORCPT ); Fri, 19 Nov 2004 08:11:21 -0500 Received: from ip-svs-1.Informatik.Uni-Oldenburg.DE ([134.106.12.126]:18411 "EHLO aechz.svs.informatik.uni-oldenburg.de") by vger.kernel.org with ESMTP id S261399AbUKSNLP (ORCPT ); Fri, 19 Nov 2004 08:11:15 -0500 Date: Fri, 19 Nov 2004 14:10:41 +0100 From: Philipp Matthias Hahn To: Kernel Mailing List , Trond Myklebust Subject: NFS hang on unlink with linux-2.4.28 again Message-ID: <20041119131041.GA7004@titan.lahn.de> Mail-Followup-To: Kernel Mailing List , Trond Myklebust References: <200411171156.iAHBuA1E013082@hera.kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411171156.iAHBuA1E013082@hera.kernel.org> Organization: UUCP-Freunde Lahn e.V. User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5188 Lines: 131 Hello! On Wed, Nov 17, 2004 at 03:56:10AM -0800, Marcelo Tosatti wrote: > Summary of changes from v2.4.28-rc2 to v2.4.28-rc3 > ============================================ > Trond Myklebust: > o NFS: Always wake up tasks that are waiting on the sillyrenamed file to complete I had had the hope, that your following patch > --- linux-2.4.27/fs/nfs/unlink.c 2004-08-07 16:26:06.000000000 -0700 > +++ linux-2.4.28/fs/nfs/unlink.c 2004-11-17 03:54:21.957412655 -0800 > @@ -130,13 +130,14 @@ > if (nfs_async_handle_jukebox(task)) > return; > if (!dir) > - return; > + goto out; > dir_i = dir->d_inode; > nfs_zap_caches(dir_i); > NFS_PROTO(dir_i)->unlink_done(dir, &task->tk_msg); > put_rpccred(data->cred); > data->cred = NULL; > dput(dir); > +out: > data->completed = 1; > wake_up(&data->waitq); > } would have fixed my hang problem, but one of our computers (NFS3 over TCP in another IP-Segment) just locked up again: rpciod S F763E000 0 2620 1 2668 2621 (L-TLB) Call Trace: [] nfs_complete_unlink+0x1c0/0x1d0 [nfs] [] nfs_dentry_iput+0x3f/0xa0 [nfs] [] dput+0x132/0x190 [kernel] [] fput+0xe7/0x140 [kernel] [] nfs_clear_request+0x86/0x90 [nfs] [] nfs_commit_done+0x2a4/0x4f0 [nfs] [] call_decode+0x125/0x240 [sunrpc] [] __rpc_execute+0x242/0x330 [sunrpc] [] schedule+0x300/0x590 [kernel] [] __rpc_execute+0x232/0x330 [sunrpc] [] __rpc_schedule+0xdc/0x160 [sunrpc] [] rpciod+0xe0/0x280 [sunrpc] [] rpciod+0x0/0x280 [sunrpc] [] arch_kernel_thread+0x2e/0x40 [kernel] [] rpciod_killer+0x0/0xc [sunrpc] [] rpciod+0x0/0x280 [sunrpc] gconfd-2 S FFFFFFFF 0 2668 1 2674 2620 (NOTLB) Call Trace: [] nfs_wait_on_request+0x131/0x140 [nfs] [] nfs_update_request+0x95/0x360 [nfs] [] nfs_updatepage+0xc9/0x2b0 [nfs] [] nfs_flush_incompatible+0x8f/0xc0 [nfs] [] nfs_commit_write+0x4a/0x80 [nfs] [] do_generic_file_write+0x289/0x480 [kernel] [] sk_free+0x58/0x90 [kernel] [] generic_file_write+0x121/0x140 [kernel] [] dput+0x31/0x190 [kernel] [] nfs_file_write+0x7a/0xe0 [nfs] [] sys_write+0xad/0x170 [kernel] [] sys_close+0x67/0x80 [kernel] [] system_call+0x33/0x38 [kernel] gnome-smproxy S 00000000 0 2676 1 2678 2674 (NOTLB) Call Trace: [] nfs_wait_on_request+0x131/0x140 [nfs] [] nfs_wait_on_requests+0x99/0xb0 [nfs] [] nfs_sync_file+0x76/0x80 [nfs] [] nfs_file_flush+0x41/0xa0 [nfs] [] filp_close+0x5d/0xd0 [kernel] [] sys_write+0x117/0x170 [kernel] [] sys_close+0x67/0x80 [kernel] [] system_call+0x33/0x38 [kernel] gnome-panel S E8EFE800 0 2808 1 2812 2784 (NOTLB) Call Trace: [] nfs_sillyrename+0x182/0x240 [nfs] [] nfs_complete_unlink+0x1c0/0x1d0 [nfs] [] nfs_dentry_iput+0x3f/0xa0 [nfs] [] dput+0x132/0x190 [kernel] [] fput+0xe7/0x140 [kernel] [] filp_close+0x8f/0xd0 [kernel] [] sys_close+0x67/0x80 [kernel] [] system_call+0x33/0x38 [kernel] gnome-termina S E019FB00 0 2895 1 2974 2814 (NOTLB) Call Trace: [] nfs_sillyrename+0x182/0x240 [nfs] [] nfs_complete_unlink+0x1c0/0x1d0 [nfs] [] nfs_dentry_iput+0x3f/0xa0 [nfs] [] dput+0x132/0x190 [kernel] [] fput+0xe7/0x140 [kernel] [] filp_close+0x8f/0xd0 [kernel] [] sys_close+0x67/0x80 [kernel] [] system_call+0x33/0x38 [kernel] emacs S 0000674D 0 2977 2974 3145 (NOTLB) Call Trace: [] nfs_wait_on_request+0x131/0x140 [nfs] [] nfs_wait_on_requests+0x99/0xb0 [nfs] [] nfs_sync_file+0x76/0x80 [nfs] [] nfs_file_flush+0x41/0xa0 [nfs] [] filp_close+0x5d/0xd0 [kernel] [] sys_write+0x117/0x170 [kernel] [] sys_close+0x67/0x80 [kernel] [] system_call+0x33/0x38 [kernel] emacs S 00000000 0 3145 2974 2977 (NOTLB) Call Trace: [] nfs_wait_on_request+0x131/0x140 [nfs] [] nfs_wait_on_requests+0x99/0xb0 [nfs] [] nfs_sync_file+0x76/0x80 [nfs] [] nfs_file_flush+0x41/0xa0 [nfs] [] filp_close+0x5d/0xd0 [kernel] [] sys_write+0x117/0x170 [kernel] [] sys_close+0x67/0x80 [kernel] [] system_call+0x33/0x38 [kernel] BYtE Philipp -- / / (_)__ __ ____ __ Philipp Hahn / /__/ / _ \/ // /\ \/ / /____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/