Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261592AbUKSVlH (ORCPT ); Fri, 19 Nov 2004 16:41:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261596AbUKSVlG (ORCPT ); Fri, 19 Nov 2004 16:41:06 -0500 Received: from sd291.sivit.org ([194.146.225.122]:59078 "EHLO sd291.sivit.org") by vger.kernel.org with ESMTP id S261592AbUKSVjH (ORCPT ); Fri, 19 Nov 2004 16:39:07 -0500 Date: Fri, 19 Nov 2004 22:39:42 +0100 From: Stelian Pop To: Christoph Hellwig , mdharm-usb@one-eyed-alien.net, Linux Kernel Mailing List , Andrew Morton Subject: Re: [PATCH] usb-storage should enable scsi disk in Kconfig Message-ID: <20041119213942.GG2700@deep-space-9.dsnet> Reply-To: Stelian Pop Mail-Followup-To: Stelian Pop , Christoph Hellwig , mdharm-usb@one-eyed-alien.net, Linux Kernel Mailing List , Andrew Morton References: <20041119193350.GE2700@deep-space-9.dsnet> <20041119195736.GA8466@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041119195736.GA8466@infradead.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 33 On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote: > On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote: > > As $subject says, usb-storage storage should automatically enable > > scsi disk support in Kconfig. > > > > Please apply. > > No, it shouldn't. There's lots of usb storage devices that don't use > sd, as there are lots of SPI/FC/etc.. devices. Indeed, I should have checked more carefully. My bad. Still, it is not obvious that one should go into a completly different config section and manually enable sd support, and I have been bitten by this more than one time. Maybe we should add, just below the 'USB storage' Kconfig option another one, let's say 'SCSI disk based USB storage support', which documentation would talk about 'usb keys, memory stick readers, USB floppy drives etc', which should just be a dummy option selecting BLK_DEV_SD ? Or perhaps we should add something along the Debian's dpkg 'suggests' rule to Kconfig ? :) Stelian. -- Stelian Pop - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/