Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261594AbUKSVn1 (ORCPT ); Fri, 19 Nov 2004 16:43:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261600AbUKSVnZ (ORCPT ); Fri, 19 Nov 2004 16:43:25 -0500 Received: from mail.kroah.org ([69.55.234.183]:3214 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S261594AbUKSVmS (ORCPT ); Fri, 19 Nov 2004 16:42:18 -0500 Date: Fri, 19 Nov 2004 13:32:32 -0800 From: Greg KH To: brking@us.ibm.com Cc: paulus@samba.org, benh@kernel.crashing.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] pci: Block config access during BIST Message-ID: <20041119213232.GB13259@kroah.com> References: <200411192023.iAJKNNSt004374@d03av02.boulder.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411192023.iAJKNNSt004374@d03av02.boulder.ibm.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 20 On Fri, Nov 19, 2004 at 02:23:22PM -0600, brking@us.ibm.com wrote: > -static inline int pci_read_config_byte(struct pci_dev *dev, int where, u8 *val) > -{ > - return pci_bus_read_config_byte (dev->bus, dev->devfn, where, val); > -} Well, as much as I despise this patch, you should at least get it correct :) You need to block the pci_bus_* functions too, otherwise the parts of the kernel that use them will stomp all over your device, right? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/