Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262735AbUKTLxz (ORCPT ); Sat, 20 Nov 2004 06:53:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262739AbUKTLxz (ORCPT ); Sat, 20 Nov 2004 06:53:55 -0500 Received: from mx1.elte.hu ([157.181.1.137]:18323 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S262735AbUKTLw1 (ORCPT ); Sat, 20 Nov 2004 06:52:27 -0500 Date: Sat, 20 Nov 2004 13:53:55 +0100 From: Ingo Molnar To: janitor@sternwelten.at Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, domen@coderock.org Subject: Re: [patch 3/8] kernel/sched.c: fix subtle TASK_RUNNING compare Message-ID: <20041120125355.GB8091@elte.hu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 18 * janitor@sternwelten.at wrote: > switch_count = &prev->nivcsw; > - if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) { > + if (prev->state != TASK_RUNNING && > + !(preempt_count() & PREEMPT_ACTIVE)) { > switch_count = &prev->nvcsw; nack. We inherently rely on the process state mask being a bitmask and TASK_RUNNING thus being zero. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/