Date: Sun, 21 Nov 2004 16:18:58 +0100
From: Adrian Bunk <bunk@stusta.de>
To: ambx1@neo.rr.com, perex@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] misc ISAPNP cleanups
Message-ID: <20041121151856.GM2829@stusta.de>
References: <20041113030234.GX2249@stusta.de> <20041116050316.GC29574@neo.rr.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041116050316.GC29574@neo.rr.com>
User-Agent: Mutt/1.5.6+20040907i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1402
Lines: 42

On Tue, Nov 16, 2004 at 12:03:16AM -0500, Adam Belay wrote:
> On Sat, Nov 13, 2004 at 04:02:34AM +0100, Adrian Bunk wrote:
> > The patch below removes some completely unused code and makes some 
> > needlessly global code static in drivers/pnp/isapnp/core.c .
> > 
> > Please review whether this patch is correct or whether it conflicts with 
> > pending ISAPNP updates/usages.
> > 
> > 
> > diffstat output:
> >  drivers/pnp/isapnp/core.c |   47 ++++++++------------------------------
> >  include/linux/isapnp.h    |   20 ----------------
> >  2 files changed, 11 insertions(+), 56 deletions(-)
> > 
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> 
> I have to check that this doesn't break any obscure isapnp drivers.  Otherwise

Why are these "obscure isapnp drivers" not included in the kernel?

> it looks good.  Some of them, like "isapnp_alloc", look obvious.
> 
> Thanks,
> Adam

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/