Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261832AbUKUWq3 (ORCPT ); Sun, 21 Nov 2004 17:46:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261834AbUKUWqO (ORCPT ); Sun, 21 Nov 2004 17:46:14 -0500 Received: from mail.dif.dk ([193.138.115.101]:4054 "EHLO mail.dif.dk") by vger.kernel.org with ESMTP id S261828AbUKUWp6 (ORCPT ); Sun, 21 Nov 2004 17:45:58 -0500 Date: Sun, 21 Nov 2004 23:55:23 +0100 (CET) From: Jesper Juhl To: Matthew Wilcox Cc: linux-fsdevel , linux-kernel Subject: [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 870 Lines: 27 Hi, This patch removes a pointless comparison. "arg" is an unsigned long, thus it can never be <0, so testing that is pointless. Signed-off-by: Jesper Juhl diff -up linux-2.6.10-rc2-bk6-orig/fs/fcntl.c linux-2.6.10-rc2-bk6/fs/fcntl.c --- linux-2.6.10-rc2-bk6-orig/fs/fcntl.c 2004-11-17 01:20:14.000000000 +0100 +++ linux-2.6.10-rc2-bk6/fs/fcntl.c 2004-11-21 23:49:20.000000000 +0100 @@ -340,7 +340,7 @@ static long do_fcntl(int fd, unsigned in break; case F_SETSIG: /* arg == 0 restores default behaviour. */ - if (arg < 0 || arg > _NSIG) { + if (arg > _NSIG) { break; } err = 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/