Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261987AbUKVI0i (ORCPT ); Mon, 22 Nov 2004 03:26:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261986AbUKVI0i (ORCPT ); Mon, 22 Nov 2004 03:26:38 -0500 Received: from witte.sonytel.be ([80.88.33.193]:47034 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S261985AbUKVI0f (ORCPT ); Mon, 22 Nov 2004 03:26:35 -0500 Date: Mon, 22 Nov 2004 09:26:19 +0100 (MET) From: Geert Uytterhoeven To: Andrew Morton cc: Christoph Hellwig , Linus Torvalds , Kars de Jong , Jeff Garzik , Linux Kernel Development , linux-net@vger.kernel.org Subject: Re: [PATCH 475] HP300 LANCE In-Reply-To: <20041121161244.1a5ff193.akpm@osdl.org> Message-ID: References: <200410311003.i9VA3UMN009557@anakin.of.borg> <20041101142245.GA28253@infradead.org> <20041116084341.GA24484@infradead.org> <20041116231248.5f61e489.akpm@osdl.org> <20041121161244.1a5ff193.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 49 On Sun, 21 Nov 2004, Andrew Morton wrote: > Geert Uytterhoeven wrote: > > On Tue, 16 Nov 2004, Andrew Morton wrote: > > > Christoph Hellwig wrote: > > > > > There's tons of leaks in the hplcance probing code, and it doesn't release > > > > > he memory region on removal either. > > > > > > > > > > Untested patch to fix those issues below: > > > > > > > > ping. > > > > > > The fix needs a fix: > > > > Indeed. > > > > And you should remove the definitions of dio_resource_{start,len}(), as they're > > already defined in linux/dio.h. > > > > But differently. Christoph had: > > +#define dio_resource_len(d) \ > + ((d)->resource.end - (d)->resource.start) > > but dio.h has: > > #define dio_resource_len(d) ((d)->resource.end-(z)->resource.start+1) > > > Which is correct? The one in linux/dio.h (i.e. incl. +1, cfr. the definitions in linux/{pci,zorro}.h, too). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/