Date: Mon, 22 Nov 2004 10:20:59 +0100
From: Jens Axboe <axboe@suse.de>
To: Tobias DiPasquale <codeslinger@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@digeo.com
Subject: Re: [PATCH] add list_del_head function
Message-ID: <20041122092059.GA16487@suse.de>
References: <876ef97a04112007562d6797e@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <876ef97a04112007562d6797e@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 29

On Sat, Nov 20 2004, Tobias DiPasquale wrote:
> Hi all,
> 
> I was working with some queues the other day and I noticed that there
> was a list_add_tail() function in list.h, but no list_del_head()
> function. This struck me as a little odd, so I went ahead and
> implemented one in order to complete full queue functionality. The
> patch below was generated against pristine 2.6.9 kernel.org kernel
> sources and is attached to this email.

Generally patches like this have little merrit unless accompanied by
another patch converting several obvious pieces of kernel code to use
it.

Also I find the interface awkward and different from the other list
functions.

	entry = list_del_head(list);

would have been much nicer.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/