Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262181AbUKWFBD (ORCPT ); Tue, 23 Nov 2004 00:01:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262161AbUKWEs4 (ORCPT ); Mon, 22 Nov 2004 23:48:56 -0500 Received: from witte.sonytel.be ([80.88.33.193]:21910 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S262343AbUKVVkw (ORCPT ); Mon, 22 Nov 2004 16:40:52 -0500 Date: Mon, 22 Nov 2004 22:33:02 +0100 (MET) From: Geert Uytterhoeven To: adaplas@pol.net cc: Linux Frame Buffer Device Development , Adrian Bunk , Linux Kernel Development Subject: Re: [Linux-fbdev-devel] Re: [2.6 patch] drivers/video/: misc cleanups In-Reply-To: <200411230446.50784.adaplas@hotpop.com> Message-ID: References: <20041121153702.GB2829@stusta.de> <200411221055.07693.adaplas@hotpop.com> <200411230446.50784.adaplas@hotpop.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2239 Lines: 57 On Tue, 23 Nov 2004, Antonino A. Daplas wrote: > On Monday 22 November 2004 17:43, Geert Uytterhoeven wrote: > > On Mon, 22 Nov 2004, Antonino A. Daplas wrote: > > > On Sunday 21 November 2004 23:58, Adrian Bunk wrote: > > > > On Sun, Nov 21, 2004 at 04:37:02PM +0100, Adrian Bunk wrote: > > > > > The patch below does the following cleanups under drivers/video/ : > > > > > - make some needlessly global code static > > > > > - the following was needlessly EXPORT_SYMBOL'ed: > > > > > - fbcon.c: fb_con > > > > > - mdacon.c: fb_blank > > > > > - fbmon.c: get_EDID_from_firmware (completely unused) > > > > >... > > > > > > > > I forgot one thing: > > > > > > > > Please review my global_mode_option removal in modedb.c . > > > > > > > > It was always NULL and I'd say the only usage was wrong (although it > > > > had no practical effect). > > > > > > Should be ok to remove it. I only see fb_find_mode using it, and as > > > you've concluded, usage is not very clear. > > > > > > BTW: The global_mode_option, previously, is filled up when no driver is > > > specified in the boot options, such as "video=1024x768@60". But this was > > > removed during the fb initialization cleanup. > > > > What a pity... It allowed people to not have to care about the name of > > their graphics driver(s)... > > > > The absence of the driver name array will make it a bit difficult to differentiate > between options passed specifically to drivers vs the global mode option. > > We can bring global_mode_option back. Since driver names always have a > terminating "fb", we can search for the "fb:" substring and if not found, > then it's a global_mode_option. > > Is that okay? Sounds fine! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/