Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262235AbUKWHIa (ORCPT ); Tue, 23 Nov 2004 02:08:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262244AbUKWHIa (ORCPT ); Tue, 23 Nov 2004 02:08:30 -0500 Received: from fmr14.intel.com ([192.55.52.68]:913 "EHLO fmsfmr002.fm.intel.com") by vger.kernel.org with ESMTP id S262235AbUKWHI0 (ORCPT ); Tue, 23 Nov 2004 02:08:26 -0500 Subject: Re: 2.6.10-rc2 doesn't boot (if no floppy device) From: Len Brown To: Linus Torvalds Cc: Adrian Bunk , Chris Wright , Bjorn Helgaas , Kernel Mailing List , Andrew Morton , Stian Jordet In-Reply-To: References: <20041115152721.U14339@build.pdx.osdl.net> <1100819685.987.120.camel@d845pe> <20041118230948.W2357@build.pdx.osdl.net> <1100941324.987.238.camel@d845pe> <20041120124001.GA2829@stusta.de> <1101151780.20006.69.camel@d845pe> <1101155893.20007.125.camel@d845pe> Content-Type: text/plain Organization: Message-Id: <1101193585.20006.533.camel@d845pe> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.3 Date: 23 Nov 2004 02:06:26 -0500 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 33 On Mon, 2004-11-22 at 23:57, Linus Torvalds wrote: > > On Mon, 22 Nov 2004, Linus Torvalds wrote: > > > Len, how about this patch - it re-enables the link disable and then > re-codes the ELCR setting to match. > > Basically it just computes the new ELCR: if acpi_noirq is set, it > leaves it at the old value, otherwise it zeroes it - and in both cases > it fixes the SCI entry. > Your argument for doing this ended up being convincing, so the only > difference between this and your debug patch is really just the > obvious organizational ones, and the test for "acpi_noirq", which I > think is needed (since if acpi_noirq is set, we're not going to > disable and re-enable the PCI interrupts, so we'll just have to trust > ELCR). I think your use of acpi_noirq in acpi_pic_sci_set_trigger() was clever -- maybe more clever than the name of the routine suggests -- but it looks correct. thanks for restoring pci_link.c -Len - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/