Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261362AbUKWXJt (ORCPT ); Tue, 23 Nov 2004 18:09:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261610AbUKWXIB (ORCPT ); Tue, 23 Nov 2004 18:08:01 -0500 Received: from rrcs-24-227-247-8.sw.biz.rr.com ([24.227.247.8]:8657 "EHLO emachine.austin.ammasso.com") by vger.kernel.org with ESMTP id S261362AbUKWXFU (ORCPT ); Tue, 23 Nov 2004 18:05:20 -0500 Message-ID: <41A3C1AE.5060604@ammasso.com> Date: Tue, 23 Nov 2004 17:03:10 -0600 From: Timur Tabi Organization: Ammasso User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040803 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jesper Juhl CC: linux-kernel Subject: Re: [PATCH] Remove pointless <0 comparison for unsigned variable in fs/fcntl.c References: <20041122010253.GE25636@parcelfarce.linux.theplanet.co.uk> <41A30612.2040700@dif.dk> <41A38BF1.9060207@ammasso.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 20 Jesper Juhl wrote: > if pid_t is 16 bit, then the value can never be greater than 0xffff but, > if pid_t is greater than 16 bit, say 32 bit, then the argument "a" could > very well contain a value greater than 0xffff and then the comparison > makes perfect sense. If pid_t is 32-bit, then what's wrong with the value being greater than 0xFFFF? After all, if pid_t a 32-bit number, that implies that 32-bit values are acceptable. -- Timur Tabi Staff Software Engineer timur.tabi@ammasso.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/