Date: Wed, 24 Nov 2004 15:25:34 +0100
From: Colin Leroy <colin@colino.net>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] let fat handle MS_SYNCHRONOUS flag
Message-ID: <20041124152534.13e07c24@pirandello>
In-Reply-To: <87pt23wdk1.fsf@devron.myhome.or.jp>
References: <20041118194959.3f1a3c8e.colin@colino.net>
	<87pt23wdk1.fsf@devron.myhome.or.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 729
Lines: 26

On 24 Nov 2004 at 23h11, OGAWA Hirofumi wrote:

Hi, 

> > +			bh = sb_bread(sb, MSDOS_SB(sb)->fsinfo_sector);
> > +			if (bh != NULL) {
> > +				sync_dirty_buffer(bh);
> > +				brelse(bh);
> > +			} else {
> > +				BUG_ON(1);
> > +			}
> > +		}
> 
> FAT12/16 doesn't have FSINFO sector.  And if sb_bread() returns NULL,
> we should return the valid error.

ok, this is probably not the correct way to get the buffer_head for a 
given inode... Do you know what I should use?

-- 
Colin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/