Subject: Re: Suspend 2 merge: 7/51: Reboot handler hook.
From: Nigel Cunningham <ncunningham@linuxmail.org>
Reply-To: ncunningham@linuxmail.org
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20041124130750.GA12730@infradead.org>
References: <1101292194.5805.180.camel@desktop.cunninghams>
	 <1101293507.5805.212.camel@desktop.cunninghams>
	 <20041124130750.GA12730@infradead.org>
Content-Type: text/plain
Message-Id: <1101327568.3425.14.camel@desktop.cunninghams>
Mime-Version: 1.0
Date: Thu, 25 Nov 2004 07:19:28 +1100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1408
Lines: 50

Hi.

On Thu, 2004-11-25 at 00:07, Christoph Hellwig wrote:
> > -#ifdef CONFIG_SOFTWARE_SUSPEND
> > +#ifdef CONFIG_SOFTWARE_SUSPEND2
> >  	case LINUX_REBOOT_CMD_SW_SUSPEND:
> >  		{
> > -			int ret = software_suspend();
> > +			int ret = -EINVAL;
> > +			if (!(test_suspend_state(SUSPEND_DISABLED))) {
> > +				suspend_try_suspend();
> > +				ret = 0;
> > +			}
> >  			unlock_kernel();
> 
> total crap.  Thbis patch breaks the existing swsusp and turns a clean
> interface into a horrible one.  Just implement am

It doesn't break the existing suspend; rather it overrides the action. I
will however tidy it up. Sorry about that; I reversed the test a while
ago and didn't notice that it could be tidier. I note though that your
solution fails to unlock_kernel().

Regards,

Nigel

> int software_suspend(void)
> {
> 	if (test_suspend_state(SUSPEND_DISABLED))
> 		return -EINVAL;
> 	suspend_try_suspend();
> 	return 0;
> }
> 
> in your code.
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

You see, at just the right time, when we were still powerless, Christ
died for the ungodly.		-- Romans 5:6

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/