Subject: Re: Suspend 2 merge: 48/51: Swapwriter
From: Nigel Cunningham <ncunningham@linuxmail.org>
Reply-To: ncunningham@linuxmail.org
To: Pavel Machek <pavel@ucw.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20041125235527.GH2909@elf.ucw.cz>
References: <1101292194.5805.180.camel@desktop.cunninghams>
	 <1101300479.5805.389.camel@desktop.cunninghams>
	 <20041125235527.GH2909@elf.ucw.cz>
Content-Type: text/plain
Message-Id: <1101427554.27250.172.camel@desktop.cunninghams>
Mime-Version: 1.0
Date: Fri, 26 Nov 2004 11:05:54 +1100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1332
Lines: 38

Hi.

On Fri, 2004-11-26 at 10:55, Pavel Machek wrote:
> Hi!
> 
> > This is the swapwriter. It is forms the glue between the highlevel I/O
> > routines in io.c and the blockwriter routines in block_io.c. It is
> > responsible for allocating storage, translating the requests for pages
> > within pagesets into devices and blocks and the like. It is abstracted
> > from the block writer because the plan is that we'll eventually have a
> > generic file writer (ie not using swapspace, but a simple file,
> > possibly
> 
> This file alone is bigger than whole swsusp1. That strongly suggests
> you have too many layers of abstraction in there. Planning for future
> is nice, but not at this cost.

Not necessarily too many layers of abstraction. It includes swapfile
support and there's a bit in there for readahead (plus the debugging you
mentioned).

Regards,

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

You see, at just the right time, when we were still powerless, Christ
died for the ungodly.		-- Romans 5:6

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/