Date: Fri, 26 Nov 2004 01:05:02 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@digeo.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Suspend 2 merge: 21/51: Refrigerator upgrade.
Message-ID: <20041126000502.GK2711@elf.ucw.cz>
References: <1101292194.5805.180.camel@desktop.cunninghams> <1101296026.5805.275.camel@desktop.cunninghams> <20041125183332.GJ1417@openzaurus.ucw.cz> <1101420616.27250.65.camel@desktop.cunninghams> <20041125223610.GC2711@elf.ucw.cz> <1101422986.27250.106.camel@desktop.cunninghams> <20041125232519.GI2711@elf.ucw.cz> <1101426572.27250.151.camel@desktop.cunninghams>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1101426572.27250.151.camel@desktop.cunninghams>
User-Agent: Mutt/1.5.6+20040722i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1077
Lines: 27

Hi!

> > > > Silently doing nothing when user asked for sync is not nice,
> > > > either. BUG() is better solution than that.
> > > 
> > > I don't think we should BUG because the user presses Sys-Rq S while
> > > suspending. I'll make it BUG_ON() and make the Sys_Rq printk & ignore
> > > when suspending. Sound reasonable?
> > 
> > Yes, that's better. ... only that it means just another hook somewhere
> > :-(.
> 
> :<. But we're only talking two or three lines. Let's keep it in
> perspective.

I think even three lines are bad. It means that swsusp is no longer
self-contained subsystem, but that it has its hooks all over the
place. And those hooks need to be maintained, too.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/