Subject: Re: Suspend 2 merge: 35/51: Code always built in to the kernel.
From: Nigel Cunningham <ncunningham@linuxmail.org>
Reply-To: ncunningham@linuxmail.org
To: Pavel Machek <pavel@ucw.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20041126000853.GL2711@elf.ucw.cz>
References: <1101292194.5805.180.camel@desktop.cunninghams>
	 <1101298112.5805.330.camel@desktop.cunninghams>
	 <20041125233243.GB2909@elf.ucw.cz>
	 <1101427035.27250.161.camel@desktop.cunninghams>
	 <20041126000853.GL2711@elf.ucw.cz>
Content-Type: text/plain
Message-Id: <1101428250.27250.188.camel@desktop.cunninghams>
Mime-Version: 1.0
Date: Fri, 26 Nov 2004 11:17:30 +1100
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1601
Lines: 44

Hi again.

On Fri, 2004-11-26 at 11:08, Pavel Machek wrote:
> Kernel boot is not expected to be interactive. I'd do
> 
> if (can_erase_image)
> 	printk("Incorrect kernel version, image killed\n");
> else
> 	panic("Can't kill suspended image");
> 

Comes down, again, to user friendliness. Just because I can erase the
image, doesn't mean I should. It may be that the user just pressed the
down arrow one too few times in lilo, and they really do have the right
kernel, but started the wrong one. Or it may be that they're still
setting up their initrd, didn't get it quite right, know that no damage
will be done and want to continue booting. We should let the user think
about what they want to do and then do it.

I need to get on with the work I planned on doing today, so I'm going to
hang up after sending this. That's not at all to say that I want you to
stop sending email; just that I won't be replying for a while.

Once again, thanks very much for your effort. It is good to be made to
defend design decisions and to see where you could do things better or
took things for granted that 'aint necessarily so.

Regards,

Nigel
-- 
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

You see, at just the right time, when we were still powerless, Christ
died for the ungodly.		-- Romans 5:6

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/