Date: 27 Nov 2004 22:17:20 -0000
Message-ID: <20041127221720.16853.qmail@science.horizon.com>
From: linux@horizon.com
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Document kfree and vfree NULL usage
Cc: kernel@linuxace.com
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 801
Lines: 22

>> -	if (mfile) {
>> -		kfree(mfile);
>> -	} else {
>> +	kfree(mfile);
>> +	if (!mfile) {
>>  		snd_printk(KERN_ERR "ALSA card file remove problem (%p)\n", file);
>>  		return -ENOENT;
>>  	}

> The above change seems to always trigger the ENOENT return, no?

No.  kfree(mfile) doesn't magically change the numerical value of mfile.
Dereferencing it now would be a bad idea, but you can still look at it.

(The ANSI C standard envisions architectures on which just *looking* at
a dangling pointer is illegal, but Linux makes slightly tighter
restrictions.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/