Subject: Re: [PATCH] Document kfree and vfree NULL usage
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: John Levon <levon@movementarian.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
In-Reply-To: <20041127233952.GA5891@compsoc.man.ac.uk>
References: <1101565560.9988.20.camel@localhost>
	 <20041127233952.GA5891@compsoc.man.ac.uk>
Date: Sun, 28 Nov 2004 10:00:22 +0200
Message-Id: <1101628822.9996.2.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 837
Lines: 19

On Sat, Nov 27, 2004 at 04:26:00PM +0200, Pekka Enberg wrote:
> > This patch adds comments for kfree() and vfree() stating that both accept
> > NULL pointers.  I audited vfree() callers and there seems to be lots of
> > confusion over this in the kernel.

On Sat, 2004-11-27 at 23:39 +0000, John Levon wrote:
> Erm, are you sure about this? Somebody had to patch OProfile because
> vfree() didn't like NULL value being passed in. When did this change?

Yes, I am sure. vfree() calls __vunmap() which returns immediately if
the passed pointer is NULL. I don't know when this changed.

		Pekka

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/