Subject: Re: [PPC64] Tweaks to ppc64 cpu sysfs information
From: Rusty Russell <rusty@rustcorp.com.au>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Andrew Morton <akpm@osdl.org>, Anton Blanchard <anton@samba.org>,
       Paul Mackerras <paulus@samba.org>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       linuxppc64-dev@ozlabs.org,
       lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20041126035959.GK11370@zax>
References: <20041126035959.GK11370@zax>
Content-Type: text/plain
Date: Mon, 29 Nov 2004 08:58:11 +1100
Message-Id: <1101679091.25347.9.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1048
Lines: 24

On Fri, 2004-11-26 at 14:59 +1100, David Gibson wrote:
> Andrew, please apply:
> 
> Currently the ppc64 sysfs code registers an entry for each possible
> cpu in sysfs, rather than just online cpus.  That makes sense, since
> the sysfs entries are needed to control onlining of the cpus.
> However, this is done even if CONFIG_HOTPLUG_CPU is not set, or if it
> is not a hotplug capable (DLPAR) machine, which is a bit misleading.
> Secondly it also registers all the other sysfs entries (mostly
> performance monitoring controls) on all possible cpus, although they
> are quite meaningless on non-online cpus.

Surely if !CONFIG_HOTPLUG_CPU, then online == possible?  If not, it
should be.  That would solve part of the problem.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/