Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262138AbUK3PoY (ORCPT ); Tue, 30 Nov 2004 10:44:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262147AbUK3PoX (ORCPT ); Tue, 30 Nov 2004 10:44:23 -0500 Received: from fw.osdl.org ([65.172.181.6]:7655 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262138AbUK3PoH (ORCPT ); Tue, 30 Nov 2004 10:44:07 -0500 Date: Tue, 30 Nov 2004 07:43:56 -0800 (PST) From: Linus Torvalds To: tvrtko.ursulin@sophos.com cc: Andrew Morton , Kernel Mailing List , marcelo.tosatti@cyclades.com, urban@teststation.com Subject: Re: [BUG ?] smbfs open always succeeds In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 26 On Tue, 30 Nov 2004 tvrtko.ursulin@sophos.com wrote: > > I investigated a bit and found a nfs_open function at > linux-2.6.9/fs/nfs/inode.c line 906 which also always returns 0. So is > this a network filesystem way of handling opens and not a bug after all? I > am not sure though that both nfs and smbfs operate in the same way and am > not claiming that. Many networked filesystems end up doing most of the _real_ permissions checking at IO time, not opens. That said, "open()" should return definitive errors as early as possible, but sometimes you really have the case that the real error only happens when you try to read or write something. Not saying that smbfs is right, just explaining that it _might_ be right. Urban, did you see the thread? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/