Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262173AbUK3QmB (ORCPT ); Tue, 30 Nov 2004 11:42:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262165AbUK3QmA (ORCPT ); Tue, 30 Nov 2004 11:42:00 -0500 Received: from mx1.redhat.com ([66.187.233.31]:11502 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262173AbUK3QlS (ORCPT ); Tue, 30 Nov 2004 11:41:18 -0500 Date: Tue, 30 Nov 2004 11:40:32 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Gerrit Huizenga cc: linux-kernel@vger.kernel.org, Andrew Morton , Rik van Riel , Chris Mason , ckrm-tech Subject: Re: [ckrm-tech] [PATCH] CKRM: 8/10 CKRM: Resource controller for prioritizing inbound network requests In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 34 On Mon, 29 Nov 2004, Gerrit Huizenga wrote: > +#ifdef CONFIG_ACCEPT_QUEUES > + tp->class_index = 0; > + for (i=0; i < NUM_ACCEPT_QUEUES; i++) { > + tp->acceptq[i].aq_tail = NULL; > + tp->acceptq[i].aq_head = NULL; > + tp->acceptq[i].aq_wait_time = 0; > + tp->acceptq[i].aq_qcount = 0; > + tp->acceptq[i].aq_count = 0; > + if (i == 0) { > + tp->acceptq[i].aq_ratio = 1; > + } > + else { > + tp->acceptq[i].aq_ratio = 0; > + } > + } > +#endif Do not litter the networking code with #ifdef sections. Use functions which are defined to nothing via static inline if disabled. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/