Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261262AbUK3WEK (ORCPT ); Tue, 30 Nov 2004 17:04:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262347AbUK3WEK (ORCPT ); Tue, 30 Nov 2004 17:04:10 -0500 Received: from mail4.bluewin.ch ([195.186.4.74]:51411 "EHLO mail4.bluewin.ch") by vger.kernel.org with ESMTP id S261262AbUK3WEI (ORCPT ); Tue, 30 Nov 2004 17:04:08 -0500 Date: Tue, 30 Nov 2004 23:04:10 +0100 From: Roger Luethi To: Jesper Juhl Cc: linux-kernel Subject: Re: [PATCH] net/via-rhine: convert MODULE_PARM to module_param Message-ID: <20041130220410.GB29947@k3.hellgate.ch> References: <20041130140309.GA6568@k3.hellgate.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux 2.6.10-rc2-bk11 on i686 X-GPG-Fingerprint: 92 F4 DC 20 57 46 7B 95 24 4E 9E E7 5A 54 DC 1B X-GPG: 1024/80E744BD wwwkeys.ch.pgp.net User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 15 On Tue, 30 Nov 2004 22:44:37 +0100, Jesper Juhl wrote: > already moved to module_param(). There's one difference though, and I > think it matters; my patch sets the permission bits so that the parameters > get exposed in sysfs (which I think is very useful), the driver in -mm > sets the perms to 0 (zero) so nothing is exposed in sysfs (less useful). I am not familiar with the issue. Can you work out with the submitter of the -mm patch why it was coded that way, and if your version is better? Roger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/