Message-ID: <41ACFFA0.2030904@pobox.com>
Date: Tue, 30 Nov 2004 18:17:52 -0500
From: Jeff Garzik <jgarzik@pobox.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
MIME-Version: 1.0
To: Roger Luethi <rl@hellgate.ch>
CC: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
       Pavel Ruzicka <pavouk@pavouk.org>
Subject: Re: [PATCH 2.6] via-rhine: WOL band-aid
References: <20041130224014.GD29947@k3.hellgate.ch>
In-Reply-To: <20041130224014.GD29947@k3.hellgate.ch>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1022
Lines: 26

Roger Luethi wrote:
> After I disabled legacy WOL (i.e. controlled by EEPROM rather than
> driver) in 2.6.9, several people reported regressions. Legacy WOL had
> worked for them, but now it didn't anymore. The Right Way (TM) to fix
> this will get the driver to set up working WOL for all hardware, but a
> simpler solution will have to do for the time being: If a user requests
> magic packet WOL, the driver re-enables legacy WOL. Yeah, I know it's
> cheating.
> 
> This version applies against -mm. I suggest to put it there for testing
> and into 2.6.11 if feedback is good.
> 
> Thanks to Pavel Ruzicka for testing.

I don't object to the patch, but I wonder if anything can be done to 
reduce the usage of "magic numbers" (numeric rather than named constants)?

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/