Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261271AbVABQcl (ORCPT ); Sun, 2 Jan 2005 11:32:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261273AbVABQcl (ORCPT ); Sun, 2 Jan 2005 11:32:41 -0500 Received: from mail-relay-3.tiscali.it ([213.205.33.43]:60041 "EHLO mail-relay-3.tiscali.it") by vger.kernel.org with ESMTP id S261271AbVABQcg (ORCPT ); Sun, 2 Jan 2005 11:32:36 -0500 Date: Sun, 2 Jan 2005 17:32:36 +0100 From: Andrea Arcangeli To: Nick Piggin Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Andrew Morton Subject: Re: VM fixes [2/4] Message-ID: <20050102163236.GI5164@dualathlon.random> References: <20041224173558.GC13747@dualathlon.random> <41D46F4A.5080505@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41D46F4A.5080505@yahoo.com.au> X-GPG-Key: 1024D/68B9CB43 13D9 8355 295F 4823 7C49 C012 DFA1 686E 68B9 CB43 X-PGP-Key: 1024R/CB4660B9 CC A0 71 81 F4 A0 63 AC C0 4B 81 1D 8C 15 C8 E5 User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 33 On Fri, Dec 31, 2004 at 08:12:42AM +1100, Nick Piggin wrote: > Andrea Arcangeli wrote: > >This is the forward port to 2.6 of the lowmem_reserved algorithm I > >invented in 2.4.1*, merged in 2.4.2x already and needed to fix workloads > >like google (especially without swap) on x86 with >1G of ram, but it's > >needed in all sort of workloads with lots of ram on x86, it's also > >needed on x86-64 for dma allocations. This brings 2.6 in sync with > >latest 2.4.2x. > > > > This looks OK to me. It really simplifies the code there a lot too. > > The only questions I have are: should it be on by default? I don't think > we ever reached an agreement. I'd say yes, after a run in -mm because it > does potentially fix corner cases where lower zones get filled with un- > freeable memory which could have been satisfied with higher zones. Great, thanks for the review! I definitely agree it should be on by default, I already had an hang report that was solved by more recent kernels and that probably can only be explained by lowmem_reserve since there aren't other mm changes in 2.6.5 based trees. > And second, any chance you could you port it to the mm patches already in > -mm? Won't be a big job, just some clashes in __alloc_pages... I already had to port to 2.6.5 too, and that's enough for now unless I first get a positive ack that it will be merged (if I hadn't more interesting things to develop, I would be happily porting it). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/