Date: Sun, 2 Jan 2005 18:41:55 -0500
From: Daniel Jacobowitz <dan@debian.org>
To: Andi Kleen <ak@muc.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, davidel@xmailserver.org,
       mh@codeweavers.com, the3dfxdude@gmail.com
Subject: Re: [PATCH] Fix typo in i386 single step changes
Message-ID: <20050102234155.GA29453@nevyn.them.org>
Mail-Followup-To: Andi Kleen <ak@muc.de>, torvalds@osdl.org,
	linux-kernel@vger.kernel.org, davidel@xmailserver.org,
	mh@codeweavers.com, the3dfxdude@gmail.com
References: <m1brc7xv98.fsf@muc.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m1brc7xv98.fsf@muc.de>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1062
Lines: 31

On Mon, Jan 03, 2005 at 12:32:19AM +0100, Andi Kleen wrote:
> 
> Fix an obvious typo in the recent i386 single stepping changes.
> 
> I would recommend to redo all the Wine etc. testing that lead to this patch
> since it probably never worked.
> 
> Signed-off-by: Andi Kleen <ak@muc.de>
> 
> --- linux-2.6.10-bk5/arch/i386/kernel/traps.c-o	Mon Jan  3 01:02:06 2005
> +++ linux-2.6.10-bk5/arch/i386/kernel/traps.c	Mon Jan  3 01:03:05 2005
> @@ -725,7 +725,7 @@
>  		if (tsk->ptrace & PT_DTRACE) {
>  			regs->eflags &= ~TF_MASK;
>  			tsk->ptrace &= ~PT_DTRACE;
> -			if (!tsk->ptrace & PT_DTRACE)
> +			if (!(tsk->ptrace & PT_DTRACE))
>  				goto clear_TF;
>  		}
>  	}

That test is still wrong... the bit is cleared on the previous line. 
Is it supposed to be testing something else entirely?

-- 
Daniel Jacobowitz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/