Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261372AbVACBPY (ORCPT ); Sun, 2 Jan 2005 20:15:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261373AbVACBPY (ORCPT ); Sun, 2 Jan 2005 20:15:24 -0500 Received: from dns.toxicfilms.tv ([150.254.37.24]:20889 "EHLO dns.toxicfilms.tv") by vger.kernel.org with ESMTP id S261375AbVACBPO (ORCPT ); Sun, 2 Jan 2005 20:15:14 -0500 X-Qmail-Scanner-Mail-From: solt2@dns.toxicfilms.tv via dns X-Qmail-Scanner-Rcpt-To: linux-net@vger.kernel.org,linux-kernel@vger.kernel.org X-Qmail-Scanner: 1.23 (Clear:RC:0(213.238.96.126):. Processed in 0.04111 secs) Date: Mon, 3 Jan 2005 02:23:50 +0100 From: Maciej Soltysiak X-Mailer: The Bat! (v3.0.1.33) UNREG / CD5BF9353B3B7091 Reply-To: Maciej Soltysiak X-Priority: 3 (Normal) Message-ID: <894949096.20050103022350@dns.toxicfilms.tv> To: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re[2]: [PATCH 2.6] Update to module_params() in 3c59x.c In-Reply-To: <41D89586.40500@osdl.org> References: <714805690.20041230154020@dns.toxicfilms.tv> <41D89586.40500@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 19 Hello Randy, Monday, January 3, 2005, 1:44:54 AM, you wrote: > Looks pretty good, a couple of minor comments below. Thanks for your hints. I noticed that this and similar work has been done by the kernel janitors in 2.6.10-kj1. I guess I should try to stick with them with patches like these. Regards, Maciej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/