Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262086AbVAEB6r (ORCPT ); Tue, 4 Jan 2005 20:58:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262174AbVAEB6p (ORCPT ); Tue, 4 Jan 2005 20:58:45 -0500 Received: from mx1.redhat.com ([66.187.233.31]:47302 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262086AbVAEB47 (ORCPT ); Tue, 4 Jan 2005 20:56:59 -0500 Date: Tue, 4 Jan 2005 20:56:10 -0500 From: Dave Jones To: Matze Braun , Takashi Iwai Cc: linux-kernel@vger.kernel.org Subject: ALSA Maestro driver spinlock bug. Message-ID: <20050105015610.GF24231@redhat.com> Mail-Followup-To: Dave Jones , Matze Braun , Takashi Iwai , linux-kernel@vger.kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 21 One of our Fedora users reported a bug that showed up with spinlock debugging enabled. sound/pci/es1968.c: es1968_measure_clock() At line 1811, we acquire &chip->reg_lock and then call snd_es1968_bob_inc(), which calls snd_es1968_bob_start(), which tries to acquire the same lock at line 885. It barfs as a result. Is it safe to move the snd_es1968_bob_inc() call before we take the lock ? Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/