Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262198AbVAECQw (ORCPT ); Tue, 4 Jan 2005 21:16:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262200AbVAECQw (ORCPT ); Tue, 4 Jan 2005 21:16:52 -0500 Received: from one.firstfloor.org ([213.235.205.2]:7097 "EHLO one.firstfloor.org") by vger.kernel.org with ESMTP id S262198AbVAECQn (ORCPT ); Tue, 4 Jan 2005 21:16:43 -0500 To: Christoph Lameter Cc: linux-kernel@vger.kernel.org Subject: Re: Prezeroing V3 [4/4]: Driver for hardware zeroing on Altix References: <41C20E3E.3070209@yahoo.com.au> From: Andi Kleen Date: Wed, 05 Jan 2005 03:16:39 +0100 In-Reply-To: (Christoph Lameter's message of "Tue, 4 Jan 2005 15:16:04 -0800 (PST)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 20 Christoph Lameter writes: > + /* Check limitations. > + 1. System must be running (weird things happen during bootup) > + 2. Size >64KB. Smaller requests cause too much bte traffic > + */ > + if (len >= BTE_MAX_XFER || len < 60000 || system_state != SYSTEM_RUNNING) > + return EINVAL; surely return -EINVAL; Also have you thought about doing a similar driver for x86/x86-64 using cache bypassing stores? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/