Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262366AbVAENb1 (ORCPT ); Wed, 5 Jan 2005 08:31:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262367AbVAENb1 (ORCPT ); Wed, 5 Jan 2005 08:31:27 -0500 Received: from ns.suse.de ([195.135.220.2]:61900 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262366AbVAENbY (ORCPT ); Wed, 5 Jan 2005 08:31:24 -0500 Date: Wed, 05 Jan 2005 14:31:22 +0100 Message-ID: From: Takashi Iwai To: Dave Jones Cc: Matze Braun , linux-kernel@vger.kernel.org Subject: Re: ALSA Maestro driver spinlock bug. In-Reply-To: <20050105015610.GF24231@redhat.com> References: <20050105015610.GF24231@redhat.com> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 15) (Security Through Obscurity) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 773 Lines: 26 At Tue, 4 Jan 2005 20:56:10 -0500, Dave Jones wrote: > > One of our Fedora users reported a bug that showed up > with spinlock debugging enabled. > > sound/pci/es1968.c: es1968_measure_clock() > > At line 1811, we acquire &chip->reg_lock > and then call snd_es1968_bob_inc(), which > calls snd_es1968_bob_start(), which tries to > acquire the same lock at line 885. > > It barfs as a result. Is it safe to move > the snd_es1968_bob_inc() call before we > take the lock ? Already fixed in the recent ALSA version. Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/