Date: Wed, 5 Jan 2005 16:07:04 -0800
From: Andrew Morton <akpm@osdl.org>
To: Nathan Lynch <nathanl@austin.ibm.com>
Cc: olh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] prohibit slash in proc directory entry names
Message-Id: <20050105160704.7dc36ca4.akpm@osdl.org>
In-Reply-To: <1104952961.10796.41.camel@pants.austin.ibm.com>
References: <20050105075357.GA12473@suse.de>
	<20050105000129.63478670.akpm@osdl.org>
	<1104952961.10796.41.camel@pants.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1378
Lines: 34

Nathan Lynch <nathanl@austin.ibm.com> wrote:
>
> proc_create() needs to check that the name of an entry to be created
>  does not contain a '/' character.
> 
>  To test, I hacked the ibmveth driver to try to call request_irq with a
>  bogus "foo/bar" devname.  The creation of the /proc/irq/1234/xxx entry
>  silently fails, as intended.  Perhaps the irq code should be made to
>  check for the failure.
> 
>  Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>
> 
>  Index: 2.6.10/fs/proc/generic.c
>  ===================================================================
>  --- 2.6.10.orig/fs/proc/generic.c	2004-12-24 21:35:40.000000000 +0000
>  +++ 2.6.10/fs/proc/generic.c	2005-01-05 18:44:56.000000000 +0000
>  @@ -551,6 +551,11 @@
>   
>   	if (!(*parent) && xlate_proc_name(name, parent, &fn) != 0)
>   		goto out;
>  +
>  +	/* At this point there must not be any '/' characters beyond *fn */
>  +	if (strchr(fn, '/'))
>  +		goto out;
>  +

hm.  From a brief code-squint I don't see how the string can ever have a
slash in it by this stage.  Unless the caller provided a non-null *parent
and we never called xlate_proc_name()?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/