Date: Wed, 5 Jan 2005 19:38:27 -0800
From: Andrew Morton <akpm@osdl.org>
To: Zhonglin Zhang <zhonglinzh@mobilesoft.com.cn>
Cc: linux-kernel@vger.kernel.org
Subject: Re: a little improvement  for vmalloc
Message-Id: <20050105193827.12d83341.akpm@osdl.org>
In-Reply-To: <1104981532.628.10.camel@milo>
References: <1104981532.628.10.camel@milo>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 863
Lines: 27

Zhonglin Zhang <zhonglinzh@mobilesoft.com.cn> wrote:
>
> In FUNCTION __vmalloc ,
> 
>  There is a statement;
> 
>  if (!size || (size >> PAGE_SHIFT) > num_physpages)
>          return NULL;

Probably the second part of the test should be removed.  If the requested
area size is

a) less than the size of the vmalloc arena and

b) more than the number of allocatable pages

then yes, the machine will have a ton of trouble allocating the memory and
will actually lock up.

But the only way that will happen is if some code is made to do a large
number of smaller vmallocs.  Nobody does a huge single vmalloc like that.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/