Subject: Re: [2.6.10-bk7] Oops: ide_dma_timeout_retry
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Simon Kirby <sim@netnation.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-Reply-To: <20050106192357.GA1760@netnation.com>
References: <20050105233359.GA2327@netnation.com>
	 <1105023683.24896.213.camel@localhost.localdomain>
	 <20050106192357.GA1760@netnation.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1105040975.17176.245.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Thu, 06 Jan 2005 20:18:22 +0000
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1197
Lines: 30

On Iau, 2005-01-06 at 19:23, Simon Kirby wrote:
> On Thu, Jan 06, 2005 at 04:30:14PM +0000, Alan Cox wrote:
> I can't seem to find a post with the SGI fixes, and I don't see anything
> from a quick skim of the bk8 and bk9 logs (problem reproduced in bk7). 
> Could you point me to the relevant thread?

Don't think it got discussed on l/k. Dunno if its in the 2.6.10bk code
yet either

        rq->errors = 0;
                                                                                
        if (!rq->bio)
                goto out;
                                                                                
        rq->sector = rq->bio->bi_sector;
        rq->current_nr_sectors = bio_iovec(rq->bio)->bv_len >> 9;
        rq->hard_cur_sectors = rq->current_nr_sectors;
        rq->buffer = bio_data(rq->bio);
out:
        return ret;


Is how the code should look at the end of ide_dma_timeout_retry (plus
your rq == NULL check I imagine)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/