Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263001AbVAFVvF (ORCPT ); Thu, 6 Jan 2005 16:51:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263056AbVAFVu3 (ORCPT ); Thu, 6 Jan 2005 16:50:29 -0500 Received: from mx1.redhat.com ([66.187.233.31]:3000 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S263001AbVAFVm5 (ORCPT ); Thu, 6 Jan 2005 16:42:57 -0500 Date: Thu, 6 Jan 2005 16:41:59 -0500 From: Dave Jones To: Jon Smirl Cc: Andi Kleen , linux-kernel@vger.kernel.org, DRI Devel Subject: Re: chasing the four level page table Message-ID: <20050106214159.GG16373@redhat.com> Mail-Followup-To: Dave Jones , Jon Smirl , Andi Kleen , linux-kernel@vger.kernel.org, DRI Devel References: <9e47339105010609175dabc381@mail.gmail.com> <9e47339105010610362fd7fffe@mail.gmail.com> <20050106193826.GC47320@muc.de> <9e4733910501061205354c9508@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e4733910501061205354c9508@mail.gmail.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 24 On Thu, Jan 06, 2005 at 03:05:49PM -0500, Jon Smirl wrote: > On 6 Jan 2005 20:38:27 +0100, Andi Kleen wrote: > > You can't use get_user_pages in this case because the AGP aperture > > can be above mem_map. If none of the callers take page_table_lock > > already you would need to add that too. I guess from the context the lock > > is not taken, but better double check. > > > > Perhaps we should add a get_user_phys() or somesuch for this. > > No where in DRM is page_table_lock being taken. Also, no other device > driver takes page_table_lock either, so that probably implies that DRM > shouldn't start doing it to. No other device driver is also doing such lowlevel stuff with page tables directly afaics. drivers/char/drm seem to be the only drivers using [pgd|pmd|pte]_offset() routines. Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/